RFR: 8278268 - (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets [v8]

Lance Andersen lancea at openjdk.java.net
Thu Dec 16 16:41:02 UTC 2021


On Mon, 13 Dec 2021 17:26:39 GMT, Markus KARG <duke at openjdk.java.net> wrote:

>> This sub-issue defines the work to be done to implement JDK-8265891 solely for the particular case of FileChannel.transferFrom(ReadableByteChannel), including special treatment of SelectableByteChannel.
>
> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Ignoring the case of intermittend zero reads as proposed by Alan Bateman
>   
>   Signed-off-by: Markus Karg <markus at headcrashing.eu>

> > We will have to separate out the added changes into its own test as we are failing sporadically on some of the windows boxes due to the execution time.
> 
> @LanceAndersen Do I understand correct, _ontop_ of the diff you sent me, you also want me to strip all 2GB tests into a separate test class, correct?

The updates that you made to add an additional test is resulting in sporadic timeouts on Windows.  

- Please revert TransferTo.Java to omit  the changes you made to it as part of this PR
- -  Yes, we should cleanup TransferTo.java  while we are addressing this test area
- Add a new test file to address your changes to ChannelInputStream found in this PR

-------------

PR: https://git.openjdk.java.net/jdk/pull/6711


More information about the nio-dev mailing list