RFR: 8278268 - (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets [v8]
Markus KARG
duke at openjdk.java.net
Thu Dec 16 17:03:54 UTC 2021
On Thu, 16 Dec 2021 16:38:15 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Ignoring the case of intermittend zero reads as proposed by Alan Bateman
>>
>> Signed-off-by: Markus Karg <markus at headcrashing.eu>
>
>> > We will have to separate out the added changes into its own test as we are failing sporadically on some of the windows boxes due to the execution time.
>>
>> @LanceAndersen Do I understand correct, _ontop_ of the diff you sent me, you also want me to strip all 2GB tests into a separate test class, correct?
>
> The updates that you made to add an additional test is resulting in sporadic timeouts on Windows.
>
> - Please revert TransferTo.Java to omit the changes you made to it as part of this PR
> - - Yes, we should cleanup TransferTo.java while we are addressing this test area
> - Add a new test file to address your changes to ChannelInputStream found in this PR
@LanceAndersen Are you sure that the sporadic timeout comes from the changes made by *this* PR? IIUC then the sporadic timeouts are found *in the master branch*, so reverting the changes from *this* PR do not bring a benefit. It would be better to separate out *all* (*even existing*) 2GB tests instead.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6711
More information about the nio-dev
mailing list