Deduplicating code in BsdUserDefinedFileAttributeView and LinuxUserDefinedFileAttributeView
Sebastian Stenzel
sebastian.stenzel at gmail.com
Tue Feb 2 19:12:27 UTC 2021
> On 2. Feb 2021, at 18:32, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
> On 02/02/2021 11:29, Sebastian Stenzel wrote:
>> :
>>
>> I would have removed the dlsym code in one go, together with the dedup and modernization. Assuming Brian has not already any uncommitted changes, should I still proceed or rather split this into two separate pull requests?
> Up to you although it might make the review easier if we clean-up the Linux implementation first. I created JDK-8260966 [1] for the consolidation work. Once you have one or two more commits then we should look as giving you Author role so that you have JBS access.
>
> -Alan
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8260966
Thank you, I will reference JDK-8260966. Since Brian said he didn't change anything so far, it'll be easier for me to combine both issues. In comparison, the dlsym diff is rather small, anyway. I think I should be able to draft a PR within the next day.
More information about the nio-dev
mailing list