RFR: JDK-8260966 (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView

Sebastian Stenzel sebastian.stenzel at gmail.com
Wed Feb 17 06:10:08 UTC 2021


> On 17. Feb 2021, at 00:45, Brian Burkhalter <bpb at openjdk.java.net> wrote:
> 
> From what I can tell these changes look all right, but I think it would be easier to understand them if they were broken up into separate PRs. One problem here is that apparently this PR was created from a branch which already had the three commits on it. This causes there to be only one webrev encompassing all the changes in the three commits at once. Had the PR been created from a branch containing only the first commit and the other commits added one by one, then at least there would be an incremental webrev showing the changes made from one commit to the next.
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/2363

Ok, then I would propose to close and recreate the PR.

I see two options: Push the first commit, wait for a review, push further commits.

Or: Have only the first commit in this new PR, create a second PR. This requires you to create another ticket for cleanup tasks.


More information about the nio-dev mailing list