RFR: JDK-8260966 (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView

Sebastian Stenzel github.com+1204330+overheadhunter at openjdk.java.net
Wed Feb 17 08:44:40 UTC 2021


On Tue, 16 Feb 2021 23:42:40 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Ok I managed to get jtreg running in a Linux container now. Looks good:
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR   
>>    jtreg:test/jdk/java/nio/file/attribute               10    10     0     0   
>> ==============================
>> TEST SUCCESS
>> 
>> Finished building target 'run-test' in configuration 'linux-x86_64-server-release'
>
> From what I can tell these changes look all right, but I think it would be easier to understand them if they were broken up into separate PRs. One problem here is that apparently this PR was created from a branch which already had the three commits on it. This causes there to be only one webrev encompassing all the changes in the three commits at once. Had the PR been created from a branch containing only the first commit and the other commits added one by one, then at least there would be an incremental webrev showing the changes made from one commit to the next.

Closing this in favour of #2604

-------------

PR: https://git.openjdk.java.net/jdk/pull/2363


More information about the nio-dev mailing list