RFR: JDK-8260966 (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView

[Sebastian Stenzel]

On Wed, 17 Feb 2021 09:53:59 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Thanks for spitting up the steps in the refactoring as it makes it easier to review. One other thing that is still creating noise in the patch is that I think your IDE or editor has changed the formatting to 8 space indent in several places where the original code in LinuxUserDefinedFileAttributeView.java was 4 space indent. We've typically used 4 space indent in this code. If you revert those indentations then I think it will reduce the size of the patch and make it easy for us to see where the real changes are.
>
>> _Mailing list message from [Sebastian Stenzel](mailto:sebastian.stenzel at gmail.com) on [nio-dev](mailto:nio-dev at openjdk.java.net):_
>> 
>> Can you show me an example, where you see an 8 space indentation?
> 
> UnixUserDefinedFileAttributeView L41, L58, L73, L125-126, L151-152, L207, ...  so looks like changes from the original code in LinuxUserDefinedFileAttributeView, might be the IDE did it. It's not a big deal, just noise in the patch.

@bplb @AlanBateman Now that there is a webrev just for the deduplication, can I already amend further changes or wait for each set of changes to be reviewed individually? Sorry, I'm still new to the processes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2604