RFR: JDK-8260966 (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView
Brian Burkhalter
bpb at openjdk.java.net
Wed Feb 17 18:09:39 UTC 2021
On Wed, 17 Feb 2021 13:10:03 GMT, Sebastian Stenzel <github.com+1204330+overheadhunter at openjdk.org> wrote:
>>> _Mailing list message from [Sebastian Stenzel](mailto:sebastian.stenzel at gmail.com) on [nio-dev](mailto:nio-dev at openjdk.java.net):_
>>>
>>> Can you show me an example, where you see an 8 space indentation?
>>
>> UnixUserDefinedFileAttributeView L41, L58, L73, L125-126, L151-152, L207, ... so looks like changes from the original code in LinuxUserDefinedFileAttributeView, might be the IDE did it. It's not a big deal, just noise in the patch.
>
> @bplb @AlanBateman Now that there is a webrev just for the deduplication, can I already amend further changes or wait for each set of changes to be reviewed individually? Sorry, I'm still new to the processes.
It might be better to split the changes across two or three PRs, as appropriate.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2604
More information about the nio-dev
mailing list