RFR: JDK-8260966 (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView

[Sebastian Stenzel]

On Wed, 17 Feb 2021 20:21:48 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> It might be better to split the changes across two or three PRs, as appropriate.
>
> Thanks for the update patch, this is much easier to read now. Overall I think this looks good with only a few minor discussion points that I'll add to the PR. I agree with @bplb that it's best to integrate this once we've finished the review. Another issue/PR can be used for the other refactoring/modernization that you want to do.

I originally intended to also add one further commit that avoids unnecessary I/O in `UnixFileStore.isExtendedAttributesEnabled()` if `UnixNativeDispatcher` doesn't support xattr at all. This is not strictly deduplication but rather an enhancement, so I'm fine with deferring it to another PR.

Also, I deduplicated code inside of `UnixUserDefinedAttributeView`. While this is in the spirit of this issue, it is a quite large diff.

Just let me know, if you think there is anything more to be done in _this_ PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2604