RFR: JDK-8260966 (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView
Alan Bateman
alanb at openjdk.java.net
Wed Feb 17 20:24:44 UTC 2021
On Wed, 17 Feb 2021 18:06:57 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> @bplb @AlanBateman Now that there is a webrev just for the deduplication, can I already amend further changes or wait for each set of changes to be reviewed individually? Sorry, I'm still new to the processes.
>
> It might be better to split the changes across two or three PRs, as appropriate.
Thanks for the update patch, this is much easier to read now. Overall I think this looks good with only a few minor discussion points that I'll add to the PR. I agree with @bplb that it's best to integrate this once we've finished the review. Another issue/PR can be used for the other refactoring/modernization that you want to do.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2604
More information about the nio-dev
mailing list