RFR: JDK-8030048: (fs) Support UserDefinedFileAttributeView/extended attributes on OS X / HFS+ [v3]

[Alan Bateman]

On Wed, 13 Jan 2021 19:01:19 GMT, Sebastian Stenzel <github.com+1204330+overheadhunter at openjdk.org> wrote:

>> This adds support for UserDefinedFileAttributeView on macOS 10.4 and newer.
>> 
>> While the main audience for this will probably be macOS users, the relevant changes take place in (mostly existing) classes carrying BSD in their names as none of this is really macOS-specific.
>> 
>> Code is mostly copied from the Linux implementation except for three differences:
>> 1. max length for attribute names is 127 bytes
>> 2. we know for sure that APFS and HFS+ support extended attributes, therefore we [simply return `true`](https://github.com/skymatic/jdk/blob/7a3619df12853bd3a44e4f49c98f35e15bceb652/src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java#L114-L118) from `supportsFileAttributeView(UserDefinedFileAttributeView.class)` for these two FS types, while for all other types support is determined experimentally in [`isExtendedAttributesEnabled(...)`](https://github.com/skymatic/jdk/blob/7a3619df12853bd3a44e4f49c98f35e15bceb652/src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java#L83-L100)
>> 3. For the aforementioned check the new `UnixConstants.ENOATTR` is added, which [seems to be macOS and BSD-specific](https://mail-index.netbsd.org/tech-kern/2012/04/30/msg013090.html).
>> 
>> As discussed in the mailing list, for ease of tracking changes it is not a goal of this patch to modernize the existing Linux implementation, nor to deduplicate anything.
>
> Sebastian Stenzel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed comments
>   that don't provide any insights not available on the native methods' man pages

src/java.base/macosx/classes/sun/nio/fs/BsdNativeDispatcher.java line 72:

> 70:      */
> 71:     static int fgetxattr(int fd, byte[] name, long valueAddress, int valueLen) throws UnixException
> 72:     {

Do you remind reformatting the changes to BsdNativeDispatcher.java to keep it consistent with the existing code and UnixNativeDispatcher?  Otherwise I think the patch is good and I can sponsor when you are ready.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2017