RFR: JDK-8030048: (fs) Support UserDefinedFileAttributeView/extended attributes on OS X / HFS+ [v3]
Sebastian Stenzel
github.com+1204330+overheadhunter at openjdk.java.net
Fri Jan 15 11:52:05 UTC 2021
On Fri, 15 Jan 2021 11:19:15 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Sebastian Stenzel has updated the pull request incrementally with one additional commit since the last revision:
>>
>> removed comments
>> that don't provide any insights not available on the native methods' man pages
>
> src/java.base/macosx/classes/sun/nio/fs/BsdNativeDispatcher.java line 72:
>
>> 70: */
>> 71: static int fgetxattr(int fd, byte[] name, long valueAddress, int valueLen) throws UnixException
>> 72: {
>
> Do you remind reformatting the changes to BsdNativeDispatcher.java to keep it consistent with the existing code and UnixNativeDispatcher? Otherwise I think the patch is good and I can sponsor when you are ready.
Tbh, I didn't find any official style guide (just for JavaFX). Should I hard wrap at 80 chars or what is the requirement here?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2017
More information about the nio-dev
mailing list