RFR: JDK-8030048: (fs) Support UserDefinedFileAttributeView/extended attributes on OS X / HFS+ [v3]
Sebastian Stenzel
github.com+1204330+overheadhunter at openjdk.java.net
Fri Jan 15 13:21:02 UTC 2021
On Fri, 15 Jan 2021 13:00:15 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Tbh, I didn't find any official style guide (just for JavaFX). Should I hard wrap at 80 chars or what is the requirement here?
>
> Sorry, there isn't an agreed JDK wide style code. When it doubt, best to keep the style consistent with the existing code in the area. The main issue with BsdNativeDispatcher is that the line breaks are in unusual places.
Oh if you're referring to the opening bracket being on a new line, that is already inconsistent in the Linux implementation, as well. If one tries to find a rule for this, it could be that the bracket should be on a new line, if the signature does't fit into a single line.
In my latest commit I think I conformed to this style.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2017
More information about the nio-dev
mailing list