RFR: JDK-8030048: (fs) Support UserDefinedFileAttributeView/extended attributes on OS X / HFS+ [v3]

[Alan Bateman]

On Fri, 15 Jan 2021 11:49:34 GMT, Sebastian Stenzel <github.com+1204330+overheadhunter at openjdk.org> wrote:

>> src/java.base/macosx/classes/sun/nio/fs/BsdNativeDispatcher.java line 72:
>> 
>>> 70:      */
>>> 71:     static int fgetxattr(int fd, byte[] name, long valueAddress, int valueLen) throws UnixException
>>> 72:     {
>> 
>> Do you remind reformatting the changes to BsdNativeDispatcher.java to keep it consistent with the existing code and UnixNativeDispatcher?  Otherwise I think the patch is good and I can sponsor when you are ready.
>
> Tbh, I didn't find any official style guide (just for JavaFX). Should I hard wrap at 80 chars or what is the requirement here?

Sorry, there isn't an agreed JDK wide style code. When it doubt, best to keep the style consistent with the existing code in the area. The main issue with BsdNativeDispatcher is that the line breaks are in unusual places.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2017