RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v4]

Markus KARG github.com+1701815+mkarg at openjdk.java.net
Fri Oct 1 15:06:36 UTC 2021


On Wed, 29 Sep 2021 22:33:41 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment for checkTransferredContents
>>   
>>   Signed-off-by: Markus Karg <markus at headcrashing.eu>
>
> test/jdk/java/nio/channels/Channels/TransferTo.java line 28:
> 
>> 26: import static org.testng.Assert.assertEquals;
>> 27: import static org.testng.Assert.assertThrows;
>> 28: import static org.testng.Assert.assertTrue;
> 
> Static imports in tests are usually grouped by convention after regular imports.

I assume this is a OpenJDK convention? Because all IDEs I used so far sorted them *before* regular imports. I will fix that.

> test/jdk/java/nio/channels/Channels/TransferTo.java line 105:
> 
>> 103:         checkTransferredContents(inputStreamProvider, outputStreamProvider, new byte[0]);
>> 104: 
>> 105:         // tests input stream with a lenght between 1k and 4k
> 
> "lenght" should be "length"

Good catch! I will fix that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5421


More information about the nio-dev mailing list