RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v4]

Markus KARG github.com+1701815+mkarg at openjdk.java.net
Fri Oct 1 15:11:32 UTC 2021


On Wed, 29 Sep 2021 22:35:29 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> The comments are much improved but inconsistent. For example some of them have `@param` and other javadoc tags and some do not. There is also some variation in detail level.

Is it essential for *this* PR that *all* comments must be consistent? I understood @AlanBateman in a way that it is enough to simply *have some* and honestly, I did not find such high quality comments in all the existing code you showed me. Regarding the detail level, it even makes sense to only go into details *where needed* IMHO to not repeat the obvious.

> On a process level, it would be better to wait for feedback on changes before integrating. This is especially so as a sponsor has to be comfortable with the content. Ideally at least one approval should be associated with the most recent commit.

Understood. I thought that it is irrelevant when I ask for integration, as I already covered all open issues and @shipilev already marked this PR as reviewed *as-is* (*without* any comments at all).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5421


More information about the nio-dev mailing list