RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v7]

Brian Burkhalter bpb at openjdk.java.net
Tue Oct 12 02:15:54 UTC 2021


On Fri, 1 Oct 2021 17:09:06 GMT, Markus KARG <duke at openjdk.java.net> wrote:

>> Using TestNG makes it easier to maintain and extend the unit test of ChannelInputStream::transferTo.
>> 
>> This change was proposed by Brian Burkhalter @blbp and requested Alan Bateman @AlanBateman.
>> 
>> *Note: A further test addition (testing 2GB+ transfers) will be added by me in a subsequent PR using TestNG once *this* PR is merged. This will need a while due to personal scheduling, also the topics are not necessarily related, hence there are separate PRs.*
>
> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed Javadoc
>   
>   Signed-off-by: Markus Karg <markus at headcrashing.eu>

Marked as reviewed by bpb (Reviewer).

The methods from line 161 onward, starting with `createRandomBytes()` would benefit from a one-line comment.

test/jdk/java/nio/channels/Channels/TransferTo.java line 69:

> 67:     private static final Random RND = RandomFactory.getRandom();
> 68: 
> 69:     @DataProvider

It would be good to have a comment here equivalent to the other public methods.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5421


More information about the nio-dev mailing list