RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v7]

Markus KARG duke at openjdk.java.net
Sat Oct 16 08:37:10 UTC 2021


On Tue, 12 Oct 2021 02:12:25 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> The methods from line 161 onward, starting with `createRandomBytes()` would benefit from a one-line comment.

Done in https://github.com/openjdk/jdk/pull/5421/commits/137d1f4ef42c3da5192874047c0a077f031ef74c.

> test/jdk/java/nio/channels/Channels/TransferTo.java line 69:
> 
>> 67:     private static final Random RND = RandomFactory.getRandom();
>> 68: 
>> 69:     @DataProvider
> 
> It would be good to have a comment here equivalent to the other public methods.

Done in https://github.com/openjdk/jdk/pull/5421/commits/5c5317f18659754b673fcc19160acec5b1a11938.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5421


More information about the nio-dev mailing list