RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v2]
Markus KARG
github.com+1701815+mkarg at openjdk.java.net
Sat Sep 11 07:09:42 UTC 2021
On Thu, 9 Sep 2021 06:26:29 GMT, Markus KARG <github.com+1701815+mkarg at openjdk.org> wrote:
>> Using TestNG makes it easier to maintain and extend the unit test of ChannelInputStream::transferTo.
>>
>> This change was proposed by Brian Burkhalter @blbp and requested Alan Bateman @AlanBateman.
>>
>> *Note: A further test addition (testing 2GB+ transfers) will be added by me in a subsequent PR using TestNG once *this* PR is merged. This will need a while due to personal scheduling, also the topics are not necessarily related, hence there are separate PRs.*
>
> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
>
> Using assert* methods instead of fail() and expectedExceptions
>
> Signed-off-by: Markus Karg <markus at headcrashing.eu>
@AlanBateman Would be great if you could accept this PR soon, as it contains the TestNG migration requested by you, and it blocks my chain of subsequent PRs for more transferTo() improvements. Thanks! :-)
-------------
PR: https://git.openjdk.java.net/jdk/pull/5421
More information about the nio-dev
mailing list