RFR: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test [v2]

Aleksey Shipilev shade at openjdk.java.net
Mon Sep 13 08:54:48 UTC 2021


On Thu, 9 Sep 2021 06:26:29 GMT, Markus KARG <github.com+1701815+mkarg at openjdk.org> wrote:

>> Using TestNG makes it easier to maintain and extend the unit test of ChannelInputStream::transferTo.
>> 
>> This change was proposed by Brian Burkhalter @blbp and requested Alan Bateman @AlanBateman.
>> 
>> *Note: A further test addition (testing 2GB+ transfers) will be added by me in a subsequent PR using TestNG once *this* PR is merged. This will need a while due to personal scheduling, also the topics are not necessarily related, hence there are separate PRs.*
>
> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Using assert* methods instead of fail() and expectedExceptions
>   
>   Signed-off-by: Markus Karg <markus at headcrashing.eu>

I think this PR is fine as it is. Additional documentation can be added in the separate PR. Maybe I am missing some subtleties here, by I find the test code pretty self-explanatory.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5421


More information about the nio-dev mailing list