RFR: 8290349: IP_DONTFRAGMENT doesn't set DF bit in IPv4 header [v2]

[Alan Bateman]

On Mon, 1 Aug 2022 08:40:23 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Passing a boolean matches what we're doing in `setIntOption0` and gets the job done. At this moment I don't see where passing `family` would be useful. Can we make that change when it's actually needed?

Okay, we can change it when we need it.


> 
> > The change to the comments [...] are a bit ugly
> 
> Agree. How about a more specific comment? Something like:
> 
> ```
> /* Mac OS does not support setting IPv4 options on IPv6 sockets. As a result, some/all IP_* options
>  are not applied to IPv4 datagrams sent from IPv6 sockets. */
> ```

The first part isn't quite right because socket level options do work, it's just IP level that are problematic. Maybe just drop the changes to Net.c rather than trying to document the macOS bugs.

-------------

PR: https://git.openjdk.org/jdk/pull/9575