RFR: 8151430: (fs) BasicFileAttributeView.setTimes should support setting file create time on OS X [v5]

[Brian Burkhalter]

On Tue, 9 Aug 2022 07:16:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8151430: Refactor for better encapsulation
>
> src/java.base/macosx/classes/sun/nio/fs/BsdFileSystemProvider.java line 70:
> 
>> 68:             boolean followLinks = Util.followLinks(options);
>> 69:             return (V) BsdFileAttributeViews.createPosixView(file, followLinks);
>> 70:         }
> 
> The update that is 10deb03d looks quite good. I just wonder about the duplicate code in BsdFileSystemProvider. Maybe it could test for UserDefiendFileAttributeFIleView, BasicFileAttrinuteView or PosixFileAttributeView so that the parameters are only processed in one place rather than 3.

Agreed, I don't like that either.

-------------

PR: https://git.openjdk.org/jdk/pull/9762