RFR: 8151430: (fs) BasicFileAttributeView.setTimes should support setting file create time on OS X [v5]

Brian Burkhalter bpb at openjdk.org
Tue Aug 9 16:46:35 UTC 2022


On Tue, 9 Aug 2022 15:02:23 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/macosx/classes/sun/nio/fs/BsdFileSystemProvider.java line 70:
>> 
>>> 68:             boolean followLinks = Util.followLinks(options);
>>> 69:             return (V) BsdFileAttributeViews.createPosixView(file, followLinks);
>>> 70:         }
>> 
>> The update that is 10deb03d looks quite good. I just wonder about the duplicate code in BsdFileSystemProvider. Maybe it could test for UserDefiendFileAttributeFIleView, BasicFileAttrinuteView or PosixFileAttributeView so that the parameters are only processed in one place rather than 3.
>
> Agreed, I don't like that either.

Revised in 0274bc5523310e0b8580be4f63acec51f0436c49.

-------------

PR: https://git.openjdk.org/jdk/pull/9762


More information about the nio-dev mailing list