RFR: 5041655: (ch) FileLock: negative param and overflow issues [v2]

Brian Burkhalter bpb at openjdk.java.net
Sat Feb 5 00:17:46 UTC 2022


> Add an implementation note to `java.nio.channels.FileLock.overlaps(long,long)` indicating that the method does not check its parameters. Adding such checks would be an incompatible change.

Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:

  5041655: Remove implNote; add special cases for negative and zero sizes; handle overflow; handle zero size on Windows; add test

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7254/files
  - new: https://git.openjdk.java.net/jdk/pull/7254/files/39167237..f97a4125

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7254&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7254&range=00-01

  Stats: 161 lines in 4 files changed: 143 ins; 2 del; 16 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7254.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7254/head:pull/7254

PR: https://git.openjdk.java.net/jdk/pull/7254


More information about the nio-dev mailing list