RFR: 8286709: (fc) FileChannel/FileChannelImpl cleanup

Alan Bateman alanb at openjdk.java.net
Thu May 26 06:45:28 UTC 2022


On Wed, 25 May 2022 18:01:00 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Clean up some verbiage and code, mostly spaces and line breaks.

src/java.base/share/classes/java/nio/channels/FileChannel.java line 1054:

> 1052:     public MemorySegment map(MapMode mode, long offset, long size,
> 1053:                              MemorySession session)
> 1054:         throws IOException {

Thanks for fixing up the formatting issues. For this one then you could put MemorySession parameter on the previous line if you want. Also have "throws IOException {" indent by 4 looks a bit odd here. It can be indented by 8 or put the "{" on the next line like the other methods in this area.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8889


More information about the nio-dev mailing list