RFR: 8286709: (fc) FileChannel/FileChannelImpl cleanup [v2]
Brian Burkhalter
bpb at openjdk.java.net
Thu May 26 16:00:23 UTC 2022
On Thu, 26 May 2022 06:42:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8286709: Clean up the cleanup
>
> src/java.base/share/classes/java/nio/channels/FileChannel.java line 1054:
>
>> 1052: public MemorySegment map(MapMode mode, long offset, long size,
>> 1053: MemorySession session)
>> 1054: throws IOException {
>
> Thanks for fixing up the formatting issues. For this one then you could put MemorySession parameter on the previous line if you want. Also have "throws IOException {" indent by 4 looks a bit odd here. It can be indented by 8 or put the "{" on the next line like the other methods in this area.
Fixed by ab19acc6174636475ab15ef7ff403782f5493926.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8889
More information about the nio-dev
mailing list