RFR: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup" [v4]

[Daniel Fuchs]

On Tue, 1 Nov 2022 16:20:32 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Added logging to SelectWhenRefused for an intermittent failure caused by unexpected wakeups, this includes trying to receive data if there is any available to identify where it is coming from.
>> 
>> I also set the test to run in othervm mode which should reduce the chances of this failure happening in the first place.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressing comments

test/jdk/java/nio/channels/DatagramChannel/SelectWhenRefused.java line 76:

> 74:                 } else {
> 75:                     break;
> 76:                 }

nit: this is OK - but in fact the else isn't even needed. My bad. We could just break after the if, whether we entered it or not, because if we reach here it means we have found what we expected: all other paths result in continue or throw. So this could just be:

if (n > 0) { ...
}
break;

-------------

PR: https://git.openjdk.org/jdk/pull/10851