RFR: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup" [v4]
Alan Bateman
alanb at openjdk.org
Tue Nov 1 18:13:23 UTC 2022
On Tue, 1 Nov 2022 16:20:32 GMT, Darragh Clarke <duke at openjdk.org> wrote:
>> Added logging to SelectWhenRefused for an intermittent failure caused by unexpected wakeups, this includes trying to receive data if there is any available to identify where it is coming from.
>>
>> I also set the test to run in othervm mode which should reduce the chances of this failure happening in the first place.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>
> addressing comments
test/jdk/java/nio/channels/DatagramChannel/SelectWhenRefused.java line 136:
> 134: }
> 135:
> 136: static boolean checkUnexpectedWakeup(DatagramChannel dc, Set<SelectionKey> selectedKeys) {
For the next iteration, would you mind dropping the selectedKeys parameter from this method. It doesn't make sense to be calling dc.receive in this loop. It would be a lot simpler to do the non-blocking dc.receive and print the sender/details when not null.
-------------
PR: https://git.openjdk.org/jdk/pull/10851
More information about the nio-dev
mailing list