RFR: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl [v3]

Alan Bateman alanb at openjdk.org
Wed Oct 26 19:25:31 UTC 2022


On Tue, 25 Oct 2022 16:00:36 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Interpose a new class `sun.nio.ch.UnixDispatcher` between `sun.nio.ch.NativeDispatcher` and its current subclasses `sun.nio.ch.DatagramDispatcher` and `sun.nio.ch.SocketDispatcher`; refactor some methods out of `sun.nio.ch.UnixFileDispatcherImpl` into this updated hierarchy.
>
> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge
>  - 8294399: Correct copyright years
>  - 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl

Marked as reviewed by alanb (Reviewer).

src/java.base/unix/native/libnio/ch/UnixDispatcher.c line 68:

> 66:     }
> 67:     preCloseFD = sp[0];
> 68:     close(sp[1]);

This looks okay, just surprising to see the init methods at the end of the .c files when the previous convention had them before the other JNI methods.

-------------

PR: https://git.openjdk.org/jdk/pull/10434


More information about the nio-dev mailing list