RFR: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl [v3]

Brian Burkhalter bpb at openjdk.org
Wed Oct 26 19:42:47 UTC 2022


On Wed, 26 Oct 2022 19:22:57 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge
>>  - 8294399: Correct copyright years
>>  - 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
>
> src/java.base/unix/native/libnio/ch/UnixDispatcher.c line 68:
> 
>> 66:     }
>> 67:     preCloseFD = sp[0];
>> 68:     close(sp[1]);
> 
> This looks okay, just surprising to see the init methods at the end of the .c files when the previous convention had them before the other JNI methods.

Fixed in ab83200d83ce853e45ee6b6addb7f4b1d400d53f.

-------------

PR: https://git.openjdk.org/jdk/pull/10434


More information about the nio-dev mailing list