RFR: 8321429: (fc) FileChannel.lock creates a FileKey containing two long index values, they could be stored as int values [v3]
Alan Bateman
alanb at openjdk.org
Fri Dec 8 07:39:15 UTC 2023
On Thu, 7 Dec 2023 18:14:38 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> The private `FileKey` fields `dwVolumeSerialNumber`, `nFileIndexHigh`, and `nFileIndexLow` are converted to `int`s to match the number of bits in their native `DWORD` counterparts. The difference in sign appears irrelevant in this case.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8321429: Compute FileKey hash code directly instead of calling Objects.hash()
src/java.base/windows/classes/sun/nio/ch/FileKey.java line 30:
> 28: import java.io.FileDescriptor;
> 29: import java.io.IOException;
> 30: import java.util.Objects;
I assume this import is left over from a previous iteration.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17009#discussion_r1420045005
More information about the nio-dev
mailing list