RFR: 8321429: (fc) FileChannel.lock creates a FileKey containing two long index values, they could be stored as int values [v3]

Brian Burkhalter bpb at openjdk.org
Fri Dec 8 17:30:16 UTC 2023


On Fri, 8 Dec 2023 07:36:05 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8321429: Compute FileKey hash code directly instead of calling Objects.hash()
>
> src/java.base/windows/classes/sun/nio/ch/FileKey.java line 30:
> 
>> 28: import java.io.FileDescriptor;
>> 29: import java.io.IOException;
>> 30: import java.util.Objects;
> 
> I assume this import is left over from a previous iteration.

Yes, I should have remove it; done in e077935ff4c1c948f9abab74eb65ff3f9d776d5b.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17009#discussion_r1420816327


More information about the nio-dev mailing list