RFR: 8136895: Writer not closed with disk full error, file resource leaked [v5]

Tue Jul 18 05:41:05 UTC 2023

On Mon, 17 Jul 2023 17:52:42 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> In`StreamEncoder::implClose`, move `flushLeftoverChar()` inside the `try` block and the closing of the underlying stream inside the `finally` block.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8136895: Remove vestigial explicit calls to close() in implClose()

test/jdk/java/io/OutputStreamWriter/CloseWriterOnFailedFlush.java line 27:

> 25:  * @bug 8136895
> 26:  * @summary Verify stream closed after write error in StreamEncoder::implClose
> 27:  */

Do you mind adding action tag(@run) ?

test/jdk/java/nio/channels/Channels/CloseWriterOnFailedFlush.java line 27:

> 25:  * @bug 8136895
> 26:  * @summary Verify channel closed after write error in StreamEncoder::implClose
> 27:  */

Do you mind adding action tag(@run) ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13503#discussion_r1266246130
PR Review Comment: https://git.openjdk.org/jdk/pull/13503#discussion_r1266245444