RFR: 8136895: Writer not closed with disk full error, file resource leaked [v5]

Brian Burkhalter bpb at openjdk.org
Tue Jul 18 15:39:07 UTC 2023


On Tue, 18 Jul 2023 05:38:29 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8136895: Remove vestigial explicit calls to close() in implClose()
>
> test/jdk/java/io/OutputStreamWriter/CloseWriterOnFailedFlush.java line 27:
> 
>> 25:  * @bug 8136895
>> 26:  * @summary Verify stream closed after write error in StreamEncoder::implClose
>> 27:  */
> 
> Do you mind adding action tag(@run) ?

[Ditto](https://openjdk.org/jtreg/tag-spec.html#DEFAULTS).

> test/jdk/java/nio/channels/Channels/CloseWriterOnFailedFlush.java line 27:
> 
>> 25:  * @bug 8136895
>> 26:  * @summary Verify channel closed after write error in StreamEncoder::implClose
>> 27:  */
> 
> Do you mind adding action tag(@run) ?

Why? It is unnecessary. See [jtreg DEFAULTS](https://openjdk.org/jtreg/tag-spec.html#DEFAULTS).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13503#discussion_r1266958688
PR Review Comment: https://git.openjdk.org/jdk/pull/13503#discussion_r1266957991


More information about the nio-dev mailing list