RFR: 8310902: (fc) FileChannel.transferXXX async close and interrupt issues [v3]

[Alan Bateman]

On Wed, 28 Jun 2023 17:31:12 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge
>>  - Make transferFromDirect more consistent
>>  - Merge
>>  - More robustness
>>  - Update
>>  - Update
>>  - Initial commit
>
> src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 561:
> 
>> 559:      * @throws ClosedChannelException if channel is closed
>> 560:      */
>> 561:     private int beforeTransfer() throws ClosedChannelException {
> 
> Should this method and `afterTransfer()` be moved up before the `*NotSupported` fields as they cover transferring both to and from?
> 
>     // beforeTransfer()
>     // afterTransfer()
>     // transferTo fields and methods
>     // transferFrom fields and methods

Alternatively, transferFromNotSupported; can be moved up so that the transfer flags are in one place.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14656#discussion_r1245557758