RFR: 8310902: (fc) FileChannel.transferXXX async close and interrupt issues [v3]
Brian Burkhalter
bpb at openjdk.org
Wed Jun 28 18:11:55 UTC 2023
On Wed, 28 Jun 2023 17:39:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 561:
>>
>>> 559: * @throws ClosedChannelException if channel is closed
>>> 560: */
>>> 561: private int beforeTransfer() throws ClosedChannelException {
>>
>> Should this method and `afterTransfer()` be moved up before the `*NotSupported` fields as they cover transferring both to and from?
>>
>> // beforeTransfer()
>> // afterTransfer()
>> // transferTo fields and methods
>> // transferFrom fields and methods
>
> Alternatively, transferFromNotSupported; can be moved up so that the transfer flags are in one place.
Either way.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14656#discussion_r1245586719
More information about the nio-dev
mailing list