RFR: 8308678: (fs) UnixPath::toRealPath needs additional permissions when running with SM (macOS) [v6]

[Alan Bateman]

On Tue, 30 May 2023 18:56:34 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> When not resolving links and the case retention algorithm cannot be run due to a security manager being in place with no read permissions for the tree to be traversed, then fall back to the result obtained without case correction.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8308678: Remove obsolete FileSystemProvider instance variable

Implementation changes are okay, just one comment. I don't have time to look at the time right now but I see Lance has been reviewing that.

Implementation changes are okay, just one comment. I don't have time to look at the time right now but I see Lance has been reviewing that.

src/java.base/unix/classes/sun/nio/fs/UnixPath.java line 909:

> 907: 
> 908:             // Obtain the directory stream pointer. It will be closed by
> 909:             // UnixDirectoryStream::closeImpl.

I think you can replace "closeImpl" with "close" in the comment, that will be a bit clearer as the try-with-resources is just below it.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14157#pullrequestreview-1452399177
PR Review: https://git.openjdk.org/jdk/pull/14157#pullrequestreview-1452400561
PR Review Comment: https://git.openjdk.org/jdk/pull/14157#discussion_r1211214496