RFR: 8308678: (fs) UnixPath::toRealPath needs additional permissions when running with SM (macOS) [v6]

Wed May 31 16:22:26 UTC 2023

On Wed, 31 May 2023 07:30:44 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8308678: Remove obsolete FileSystemProvider instance variable
>
> src/java.base/unix/classes/sun/nio/fs/UnixPath.java line 909:
> 
>> 907: 
>> 908:             // Obtain the directory stream pointer. It will be closed by
>> 909:             // UnixDirectoryStream::closeImpl.
> 
> I think you can replace "closeImpl" with "close" in the comment, that will be a bit clearer as the try-with-resources is just below it.

Good point. So changed in ac0936c78b24ebe5132f89018dd905ea043ce92b.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14157#discussion_r1211979615