RFR: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out [v2]

[Alan Bateman]

On Tue, 14 Nov 2023 18:01:44 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Please find here a fix for a timeout issue observed in DatagramChannel/Connect.java
>> 
>> The suspicion is that the responder may have received some message from some other source and replied to that, leaving the initiator waiting forever.
>> 
>> The proposed fix makes sure the messages exchanged are unique and identifiable and ensure that both the initiator and responder will discard any message that do not have the expected content.
>> 
>> Additional logging should help with diagnosis if the test fails again.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor cleanup 3

test/jdk/java/nio/channels/DatagramChannel/Connect.java line 46:

> 44: 
> 45:     static final PrintStream log = System.err;
> 46:     static final String NOW = Instant.now().toString();

Would it be possible to rename "log" to "err" so it's a bit clearer at the use-sites where the output is going?

Also I think we should rename "NOW" as it's the time that the class is initialized so very confusing at every usage.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16661#discussion_r1395735788