RFR: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out [v2]

Daniel Fuchs dfuchs at openjdk.org
Thu Nov 16 16:41:51 UTC 2023


On Thu, 16 Nov 2023 13:57:56 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor cleanup 3
>
> test/jdk/java/nio/channels/DatagramChannel/Connect.java line 46:
> 
>> 44: 
>> 45:     static final PrintStream log = System.err;
>> 46:     static final String NOW = Instant.now().toString();
> 
> Would it be possible to rename "log" to "err" so it's a bit clearer at the use-sites where the output is going?
> 
> Also I think we should rename "NOW" as it's the time that the class is initialized so very confusing at every usage.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16661#discussion_r1396019501


More information about the nio-dev mailing list