RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v9]

Severin Gehwolf sgehwolf at openjdk.org
Wed Oct 4 19:00:54 UTC 2023


On Wed, 4 Oct 2023 17:15:20 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use custom but compatible statx struct always
>
> src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 722:
> 
>> 720:         }
>> 721:     }
>> 722: #endif
> 
> Are you missing a return here or did you really intent to call both  `statx` and `lstat64` ?

Good catch! The original code had this in `if () ... else ...` blocks. Will fix. It needs to get fixed elsewhere too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1346326389


More information about the nio-dev mailing list