RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v10]
Severin Gehwolf
sgehwolf at openjdk.org
Wed Oct 4 19:15:01 UTC 2023
> Please review this nio change which adds `BasicFileAttributes.creationTime()` support for Linux by means of the `statx` Linux specific system call. The patch does a dynamic lookup of the function and if it is available, uses it to set the support birth time capability in `UnixNativeDispatcher`. When `statx` is not available, it won't use it and fall back to the old behaviour on such systems. It should, however, compile fine on Linux systems not supporting the `statx` system call.
>
> Testing:
> - [x] GHA (MacOS X failure seems unrelated)
> - [x] `java.nio` tests.
> - [x] Manual builds and tests on older glibc versions (2.17 => fallback, 2.28+ => works). Compiles fine and falls back to the not supported case as it was before this patch.
>
> Thoughts?
Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
Add missing returns when statx is available
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15792/files
- new: https://git.openjdk.org/jdk/pull/15792/files/a196c822..ad428030
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15792&range=09
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15792&range=08-09
Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/15792.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15792/head:pull/15792
PR: https://git.openjdk.org/jdk/pull/15792
More information about the nio-dev
mailing list