RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v10]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Oct 9 10:08:17 UTC 2023
On Sat, 7 Oct 2023 12:58:17 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add missing returns when statx is available
>
> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 96:
>
>> 94: System.out.println("[Linux] Debug: supportsCreationTimeRead == " + supportsCreationTimeRead);
>> 95: // Creation time updates are not supported on Linux
>> 96: supportsCreationTimeWrite = false;
>
> It might be simpler to use `Linker.nativeLinker().defaultLookup().find("statx").isPresent()` as that would avoid adding CreationTimeHelper. JEP 454 is proposed to target 22 so the test won't need @enablePreview.
OK. If I use that this patch will have to wait for https://github.com/openjdk/jdk/pull/15103 to get integrated before this can be merged (avoiding the need to add `@enablePreview`). But that should happen fairly soon so it should be fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1350058442
More information about the nio-dev
mailing list