RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v10]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Oct 9 10:27:11 UTC 2023
On Mon, 9 Oct 2023 09:25:55 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java line 96:
>>
>>> 94: System.out.println("[Linux] Debug: supportsCreationTimeRead == " + supportsCreationTimeRead);
>>> 95: // Creation time updates are not supported on Linux
>>> 96: supportsCreationTimeWrite = false;
>>
>> It might be simpler to use `Linker.nativeLinker().defaultLookup().find("statx").isPresent()` as that would avoid adding CreationTimeHelper. JEP 454 is proposed to target 22 so the test won't need @enablePreview.
>
> OK. If I use that this patch will have to wait for https://github.com/openjdk/jdk/pull/15103 to get integrated before this can be merged (avoiding the need to add `@enablePreview`). But that should happen fairly soon so it should be fine.
For now I'm still using `@enablePreview` and will drop before integration once it's ready.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1350119526
More information about the nio-dev
mailing list