RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v10]

Mon Oct 9 10:27:09 UTC 2023

On Sat, 7 Oct 2023 13:09:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add missing returns when statx is available
>
> src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 281:
> 
>> 279:                          int follow_symlink) {
>> 280:     if (follow_symlink == NO_FOLLOW_SYMLINK) {
>> 281:       flags |= AT_SYMLINK_NOFOLLOW;
> 
> I think it would be better if statx_wrapper had the same signature as statx. Have you tried adding the AT_SYMLINK_NOFOLLOW flag at the use-site?

Sure, I can do that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1350115255