RFR: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux [v10]

[Alan Bateman]

On Wed, 4 Oct 2023 19:15:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this nio change which adds `BasicFileAttributes.creationTime()` support for Linux by means of the `statx` Linux specific system call. The patch does a dynamic lookup of the function and if it is available, uses it to set the support birth time capability in `UnixNativeDispatcher`. When `statx` is not available, it won't use it and fall back to the old behaviour on such systems. It should, however, compile fine on Linux systems not supporting the `statx` system call.
>> 
>> Testing:
>> - [x] GHA (MacOS X failure seems unrelated)
>> - [x] `java.nio` tests.
>> - [x] Manual builds and tests on older glibc versions (2.17 => fallback, 2.28+ => works). Compiles fine and falls back to the not supported case as it was before this patch.
>> 
>> Thoughts?
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing returns when statx is available

src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 281:

> 279:                          int follow_symlink) {
> 280:     if (follow_symlink == NO_FOLLOW_SYMLINK) {
> 281:       flags |= AT_SYMLINK_NOFOLLOW;

I think it would be better if statx_wrapper had the same signature as statx. Have you tried adding the AT_SYMLINK_NOFOLLOW flag at the use-site?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15792#discussion_r1349519444