RFR: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS [v2]

[Alan Bateman]

On Mon, 9 Oct 2023 19:00:02 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Change `BsdFileStore.supportsFileAttributeView` to return false for POSIX attributes when the associated volume file system type is FAT32.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8317687: Return false for "unix" view of FAT

Marked as reviewed by alanb (Reviewer).

src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java line 106:

> 104:         // POSIX attributes not supported on FAT
> 105:         if (type == PosixFileAttributeView.class &&
> 106:             entry().fstype().equals("msdos"))

The check would be easier to read if it were on one line.

BTW: Shouldn't this say "FAT32" rather than "FAT"?

-------------

PR Review: https://git.openjdk.org/jdk/pull/16084#pullrequestreview-1674005323
PR Review Comment: https://git.openjdk.org/jdk/pull/16084#discussion_r1356729152