RFR: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS [v2]

Brian Burkhalter bpb at openjdk.org
Thu Oct 12 15:17:36 UTC 2023


On Thu, 12 Oct 2023 12:18:21 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8317687: Return false for "unix" view of FAT
>
> src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java line 106:
> 
>> 104:         // POSIX attributes not supported on FAT
>> 105:         if (type == PosixFileAttributeView.class &&
>> 106:             entry().fstype().equals("msdos"))
> 
> The check would be easier to read if it were on one line.
> 
> BTW: Shouldn't this say "FAT32" rather than "FAT"?

Yes. Same story in `LinuxFileStore`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16084#discussion_r1356982609


More information about the nio-dev mailing list