RFR: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS [v2]

Thu Oct 12 15:38:42 UTC 2023

On Thu, 12 Oct 2023 15:15:05 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/macosx/classes/sun/nio/fs/BsdFileStore.java line 106:
>> 
>>> 104:         // POSIX attributes not supported on FAT
>>> 105:         if (type == PosixFileAttributeView.class &&
>>> 106:             entry().fstype().equals("msdos"))
>> 
>> The check would be easier to read if it were on one line.
>> 
>> BTW: Shouldn't this say "FAT32" rather than "FAT"?
>
> Yes. Same story in `LinuxFileStore`.

Comments so change in 853caa1b4b3360c5026b0c6df11c61825234a302.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16084#discussion_r1357012113