RFR: 8306308: (ch) Writer created by Channels::newWriter may lose data [v8]

Brian Burkhalter bpb at openjdk.org
Fri Oct 20 17:47:37 UTC 2023


On Fri, 20 Oct 2023 17:35:42 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8306308: Really fix test
>
> test/jdk/java/nio/channels/Channels/NewWriter.java line 76:
> 
>> 74:                 writer.flush();
>> 75:                 System.out.println(i);
>> 76:                 actual++;
> 
> incrementing `actual` here feels weird; could you remove this, and adjust EXPECTED instead?

Yeah I think you are right; will do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16207#discussion_r1367327488


More information about the nio-dev mailing list