RFR: 8306308: (ch) Writer created by Channels::newWriter may lose data [v8]
Brian Burkhalter
bpb at openjdk.org
Fri Oct 20 17:56:10 UTC 2023
On Fri, 20 Oct 2023 17:44:30 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> test/jdk/java/nio/channels/Channels/NewWriter.java line 76:
>>
>>> 74: writer.flush();
>>> 75: System.out.println(i);
>>> 76: actual++;
>>
>> incrementing `actual` here feels weird; could you remove this, and adjust EXPECTED instead?
>
> Yeah I think you are right; will do.
Changed in d246a4b6ebfafa9d3fb15c97cffad334ff7f9f91; thanks,
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16207#discussion_r1367331734
More information about the nio-dev
mailing list